[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [csmith-dev] astyle and csmith

Thanks David!

Out of curiosity: Could I ask people to speak up who would be inconvenienced by a global reformat of Csmith?


On 10/23/15 9:22 PM, David Blaikie wrote:
clang-format does have tools for formatting patches rather than whole
files (git-clang-format for git integration too). That's the way the
LLVM project's been doing it - not with any policy, just having a format
config that describes the project, then contributors can use it (&
sometimes suggest using it in code reviews if the formatting looks off
in some way) & if a particular file is really far from the prevailing
style and you're going to make a bunch of changes, sometimes a whole
file is formatted ahead of those changes.

On Fri, Oct 23, 2015 at 12:10 PM, John Regehr <regehr@cs.utah.edu
<mailto:regehr@cs.utah.edu>> wrote:

    If we were going to use an automatic formatting tool, I would choose
    clang-format, but I'm pretty sure that doing something like this is
    not very high on our list of priorities and I think it would cause
    major problems for anyone maintaining their own patched version of
    Csmith, or working on a patch that isn't submitted yet.

    I do agree that it would be nice to have uniform formatting.


    On 10/23/15 3:55 PM, Eric Eide wrote:

        "Gerlach, Jens" <jens.gerlach@fokus.fraunhofer.de
        <mailto:jens.gerlach@fokus.fraunhofer.de>> writes:

            Does the csmith project uses astyle (or another tool) for
            formatting csmith’s
            C++ source?