[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[csmith-project/csmith] 3e955b: custom_stdint: define int8_t as signed char



  Branch: refs/heads/master
  Home:   https://github.com/csmith-project/csmith
  Commit: 3e955b668b28bb9b5aaf55181c15292c42a09c58
      https://github.com/csmith-project/csmith/commit/3e955b668b28bb9b5aaf55181c15292c42a09c58
  Author: Sebastian Bøe <sebastianbooe@gmail.com>
  Date:   2016-05-15 (Sun, 15 May 2016)

  Changed paths:
    M runtime/custom_stdint_x86.h

  Log Message:
  -----------
  custom_stdint: define int8_t as signed char

I am no C standard expert, but after a lot of debugging and reading I
think that int8_t should be defined as signed char instead of char.

AFAICT the signedness of char is implementation defined so when
comparing toolchains with this header file you can get false-positives.

PS: I see that stdint_ia32.h defines int8_t as "signed char" so applying
this patch will make custom_stdint_x86.h consistent with stdint_ia32.h.


  Commit: 89068cf20070a9cf31a7002e93aa2fa8c794655d
      https://github.com/csmith-project/csmith/commit/89068cf20070a9cf31a7002e93aa2fa8c794655d
  Author: Yang Chen <chenyang@cs.utah.edu>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M runtime/custom_stdint_x86.h

  Log Message:
  -----------
  Merge pull request #36 from SebastianBoe/custom_stdint_int8_t

custom_stdint: define int8_t as "signed char"


Compare: https://github.com/csmith-project/csmith/compare/d100bd1a1b54...89068cf20070