[creduce-bugs] Path comparison without realpath

Subject: [creduce-bugs] Path comparison without realpath

From: Julien Cretin <julien.cretin@polytechnique.org>

Date: Mon, 7 Apr 2014 19:13:16 +0200

Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polytechnique.org; s=gapps; h=mime-version:from:date:message-id:subject:to:content-type; bh=2qtvFpJNjGvtOHlznZW+NhAwLDqkZwpU5tx6ChLWLQ8=; b=NsnPU2B0uBt718qUirXaSr90Z4owCk7lhUz7Yf7rMN9oo73SZhKOoz2lLv0gP6k7vJ pYu4sv/E5bb00brNx3KnaTL9Wnx0sNg9f9xv0i8MpUqkdr7tB9tT1eagl5y6Kg/h6iGC 3s96u5YeCWCxlaZaLHQXRo2kRq7jaubfAoQfw=

List-archive: </listarchives/creduce-bugs>

List-help: <mailto:creduce-bugs-request@flux.utah.edu?subject=help>

List-id: C-Reduce Bugs Mailing List <creduce-bugs.flux.utah.edu>

List-post: <mailto:creduce-bugs@flux.utah.edu>

List-subscribe: <http://www.flux.utah.edu/mailman/listinfo/creduce-bugs>, <mailto:creduce-bugs-request@flux.utah.edu?subject=subscribe>

List-unsubscribe: <http://www.flux.utah.edu/mailman/options/creduce-bugs>, <mailto:creduce-bugs-request@flux.utah.edu?subject=unsubscribe>

Hi creduce-bugs,

I tried to use creduce on a new machine and I got a problem about some prereqs not found. After investigation, I found out that the check_prereqs functions of pass_clang and pass_clex were comparing $FindBin::Bin with bindir to find out whether the executable is in the installation directory or the source directory. The problem is that in my current configuration, bindir (which I gave at installation time) goes through a symbolic link and $FindBin::Bin is a canonical path. As a consequence, creduce thinks the executable is in the source directory and cannot find some other executables.

Using Cwd::realpath(bindir) instead of bindir in the comparisons works for me (a patch is attached). I suspect that storing bindir correctly in creduce_config.pm from start should also work, but I don't know perl and configure enough to test it.

Anyway, thanks for this great tool!

Julien

diff --git a/tis-creduce-installer/creduce-2.1.0/creduce/pass_clang.pm b/tis-creduce-installer/creduce-2.1.0/creduce/pass_clang.pm index 9b19c72..d1d8cb8 100644 --- a/tis-creduce-installer/creduce-2.1.0/creduce/pass_clang.pm +++ b/tis-creduce-installer/creduce-2.1.0/creduce/pass_clang.pm @@ -30,7 +30,7 @@ my $ORIG_DIR; sub check_prereqs () { $ORIG_DIR = getcwd(); my $path; - if ($FindBin::Bin eq bindir) { + if ($FindBin::Bin eq Cwd::realpath(bindir)) { # This script is in the installation directory. # Use the installed `clang_delta'. $path = libexecdir . "/clang_delta"; diff --git a/tis-creduce-installer/creduce-2.1.0/creduce/pass_clex.pm b/tis-creduce-installer/creduce-2.1.0/creduce/pass_clex.pm index 3183e25..f24aa2a 100644 --- a/tis-creduce-installer/creduce-2.1.0/creduce/pass_clex.pm +++ b/tis-creduce-installer/creduce-2.1.0/creduce/pass_clex.pm @@ -30,7 +30,7 @@ my $ORIG_DIR; sub check_prereqs () { $ORIG_DIR = getcwd(); my $path; - if ($FindBin::Bin eq bindir) { + if ($FindBin::Bin eq Cwd::realpath(bindir)) { # This script is in the installation directory. # Use the installed `clex'. $path = libexecdir . "/clex";